Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Parameters around Layered class #1045

Merged
merged 42 commits into from
Feb 15, 2021
Merged

Restructure Parameters around Layered class #1045

merged 42 commits into from
Feb 15, 2021

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Feb 11, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 11, 2021
@jrapin jrapin mentioned this pull request Feb 12, 2021
Closed
7 tasks
jrapin
jrapin commented Feb 12, 2021
View reviewed changes
nevergrad/parametrization/test_parameter.py

def test_scalar_module() -> None:
ref = par.Scalar()
x = par.Scalar(10) % 4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may help with circular parameters #759

@jrapin jrapin changed the title [WIP] Restructure Parameters around overridable [WIP] Restructure Parameters around Layered class Feb 12, 2021
@jrapin jrapin self-assigned this Feb 15, 2021
@jrapin jrapin changed the title [WIP] Restructure Parameters around Layered class Restructure Parameters around Layered class Feb 15, 2021
@jrapin jrapin merged commit 3a4a818 into facebookresearch:master Feb 15, 2021
@jrapin jrapin deleted the overridable branch February 15, 2021 16:22
@jrapin jrapin mentioned this pull request Mar 8, 2021
Open
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrapin jrapin

Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: High Priority: Critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot